Re: [PATCH 1/4] Add history graph API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, 6 Apr 2008, Adam Simpkins wrote:

> diff --git a/graph.h b/graph.h
> new file mode 100644
> index 0000000..fc23bf2
> --- /dev/null
> +++ b/graph.h
> @@ -0,0 +1,57 @@
> +#ifndef GRAPH_H
> +#define GRAPH_H
> +
> +/* A graph is a pointer to this opaque structure */
> +struct git_graph;
> +
> +/* Defined in commit.h */
> +struct commit;
> +/* Defined in strbuf.h */
> +struct strbuf;

You do not need those.

Apart from that, it looks very, very clean to me.  (Except maybe the 
prefix ++ that could have been a postfix ++ in the line before, but that 
is just me.)

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux