Hi, On Sat, 5 Apr 2008, Kevin Ballard wrote: > diff --git a/builtin-fetch.c b/builtin-fetch.c > index a11548c..5841b3e 100644 > --- a/builtin-fetch.c > +++ b/builtin-fetch.c > @@ -637,6 +637,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) > if (!strcmp(argv[i], "tag")) { > char *ref; > i++; > + if (i >= argc) > + die("You need to specify a tag name."); Would it not be better to check in the if() above? IOW if (i + 1 < argc && !strcmp(argv[i], "tag")) { Hmm? Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html