Re: Bug in .gitignore handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linus Torvalds wrote:
On Wed, 26 Mar 2008, Tommy Thorn wrote:
My desperate attempts "./foo" and "^foo" also didn't work. Please note that
this is a vastly simplified version of the real problem, so I can't just use
"!mousetrap/foo".

It seems "foo/" _should_ work even though foo isn't a directory.

Close but no cigar.

Use "/foo" and it should be ok.

Basically, a path with a slash in it is considered absolute, but if the slash is at the end it will only match a directory. A slash at the *beginning* will match the root of the git repository, though.

D'oh, of course that works. I double check the documentation and it actually isn't obvious that that is allowed, so I propose this patch.

Tommy


From c0a003e995e325d5d9e056137b4b02c370c9dc03 Mon Sep 17 00:00:00 2001
From: Tommy Thorn <tommy-git@xxxxxxxx>
Date: Wed, 26 Mar 2008 13:34:34 -0700
Subject: [PATCH] Documentation/gitginore.txt: Be explicit about the /foo form

Signed-off-by: Tommy Thorn <tommy-git@xxxxxxxx>
---
Documentation/gitignore.txt |    3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index e847b3b..941a8a4 100644
--- a/Documentation/gitignore.txt
+++ b/Documentation/gitignore.txt
@@ -57,6 +57,9 @@ Patterns have the following format:
   included again.  If a negated pattern matches, this will
   override lower precedence patterns sources.

+ - If the pattern begins with a slash '/', the pattern will only
+   match in the current directory.
+
 - If the pattern ends with a slash, it is removed for the
   purpose of the following description, but it would only find
   a match with a directory.  In other words, `foo/` will match a
--
1.5.5.rc1

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux