Re: [PATCH] mktag.c: improve verification of tagger field and tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 26, 2008 at 1:40 AM, Brandon Casey <casey@xxxxxxxxxxxxxxx> wrote:
>  Well, since I looked at this code and used it in filter-branch, I figured I
>  should fix the verification code for the tagger field (even though it's
>  probably dieing soon).
>
>  I'm thinking this utility should be fairly strict about the format it accepts.

Why not using git-tag to make tags in filter-branch?

git-mktag was used in git-tag.sh before convert it into
builtin-tag.c, and I didn't know that anyone was using it.

I agree that, if this program exists and it is used,
we should double-check the accepted format and data,
so this patch is a good addition.

However, I think that we should progressively deprecate its
use to avoid mantaining two different ways for creating tags,
so you must have a very good reason to keep using
this tool in a script...

Regards

--
Carlos
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux