On Tue, Mar 25, 2008 at 01:47:05PM -0700, Junio C Hamano wrote: > > I stuck this in my config and it works-for-me: > > > > [format] > > headers = \ > > "MIME-Version: 1.0\n\ > > Content-Type: text/plain; charset=UTF-8\n\ > > Content-Transfer-Encoding: 8bit\n" > > I suspect that you shouldn't do this. This would badly interfere both > with existing format-patch behaviour that adds these MIME-Version and > Content-Type headers by looking at the contents, and with recent > format-patch fix 6bf4f1b (format-patch: generate MIME header as needed > even when there is format.header, 2008-03-14) to make the detection based > on contents (and presense of format.headers). Yes, I can confirm that that is problematic without even testing. The whole point of 6bf4f1b was that we _should_ add MIME headers even if the user has set format.headers. We could be more clever about parsing format.headers and mark the "we have already added MIME" flag (I think we already have to do such parsing because of to/cc magic). But I have to wonder what the real goal is here. There has sometimes been a call for "please add MIME headers unconditionally"; maybe that is an option that people would like. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
