Shawn O. Pearce escreveu:
Hmm. How long does C Git take for "git rev-list HEAD >/dev/null" ?
I have thus far only tuned the lower level machinary, and there
may still be tuning left there, but I _really_ have not tried to
tune the plotting portion yet.
I'll do that when I get back home, but I think it should be fast. At
least gitk was showing the repo fast enough, from calling it from the
command line and gitk stoping visible activity, I'd say around 2 or 3
seconds.
Maybe my problem was with the plotting part. I was running on linux.
Another thing is how many pack files/loose objects do you have?
The loose objects are harder to access, and jgit is currently
lacking some of the pack search tricks that C Git uses to get
good performance. As such all of my testing has been working on
a fully packed repository that has exactly one packfile in it,
with no alternates.
I made a clone of it and never changed it. Don't recall making fetches
either, so it should be in good shape. I can confirm later.
Oversight/planned loss of feature. I'm a strong believer of showing
the commit message *exactly* as recorded, which means don't do
line wrapping of it. Things like character encoding translation
and indenting the left side 2-4 spaces to keep it unambiguous from
headers is fine when showing it to a human, but otherwise it should
match what the user wrote.
I forgot to offer a wrap option. If we do enable line wrapping I
think we should give the user a way to toggle it on/off for the
message area viewer so that if line wrapping is enabled and its
borking the current message (e.g. a nice pretty ASCII diagram)
you can disable it.
I understand that you guys use a lot of ASCII art and wrapping can mess
this. But here we track more things in bugzilla and there's some
copy&pasting going on, so wrapping makes comments more readable.
Currently it's a toogle preference in the local toolbar menu (like the
CVS plugin).
I left the comment on the right side because it's easy to set/unset
wrapping for the whole viewer, and also for consistency with the CVS/SVN
plugins, I still use them :)
My last patches also added the changed files in the left pane as text.
The next step would be to add links. Before doing this I thought about
adding a table there (like what you did) but I chose text with links
because of copy&paste, I find it convenient to paste selected commit
info into IM or email.
[]s,
Roger.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
