Re: [PATCH] [RFC] add Message-ID field to log on git-am operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 23, 2008 at 11:32:08AM -0700, Junio C Hamano wrote:
> Anton Gladkov <agladkov@xxxxxxxxxxxxx> writes:
> > ...
> > applypatch-msg hook executed on message applying, after that there could be
> > useful to test applied patch, so it is not the place for notification sending.
> 
> And nobody suggested to send anything from the hook.
> 
> As I understood from your e-mail without proposed commit log message, your
> assumed workflow was:
> 
> 	receive mail
>         "git am" it
> 	test rewrite amend whatever you want to convince yourself that
>          the received patch was Ok
>         push the result out
>         pushed-into repository has a hook to send notification,
>          by picking up the Message-ID from the commit object

That is it.

> 
> The only thing you need was that the message-id information is available
> somewhere in the commit object.  I objected to your patch that puts it in
> the commit object header and suggested it be placed in the commit log
> message.  You can implement such custom commit munging to add an extra
> Message-ID: line inside the hook.  You do not have to send out e-mail nor
> anything from it.

I've got your idea! Thank you :)

-- 
Best regards,
		anton
mailto:agladkov@xxxxx
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux