Re: [PATCH resend 1/2] Make git-svn tests behave better on OS X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Wong <normalperson@xxxxxxxx> writes:

> Kevin Ballard <kevin@xxxxxx> wrote:
> ...
> I seem to recall seeing a RHEL or CentOS machine using /usr/sbin/httpd,
> somewhere, too.  Any non-Debian users care to comment/add more paths?
> ...
>> -SVN_HTTPD_MODULE_PATH=${SVN_HTTPD_MODULE_PATH-'/usr/lib/apache2/modules'}
>> -SVN_HTTPD_PATH=${SVN_HTTPD_PATH-'/usr/sbin/apache2'}
>> +if test `uname -s` = Darwin
>> +then
>> +	SVN_HTTPD_MODULE_PATH=${SVN_HTTPD_MODULE_PATH-'/usr/libexec/apache2'}
>> +	SVN_HTTPD_PATH=${SVN_HTTPD_PATH-'/usr/sbin/httpd'}
>> +else
>> +	SVN_HTTPD_MODULE_PATH=${SVN_HTTPD_MODULE_PATH-'/usr/lib/apache2/modules'}
>> +	SVN_HTTPD_PATH=${SVN_HTTPD_PATH-'/usr/sbin/apache2'}
>> +fi

I really hate this patch.

Why do we even _care_ about uname?

Wouldn't something like this be a lot easier to maintain in the longer run?

    for d in \
            "$SVN_HTTPD_MODULE_PATH" \
            /usr/lib/apache2/modules \
            /usr/libexec/apache2 \
    ; do
            if test -d "$d"
            then
                    SVN_HTTPD_MODULE_PATH="$d"
                    break
            fi
    done
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux