On Mon, Mar 17, 2008 at 04:09:30PM +0100, Jakub Narebski wrote: > If caching is turned on project details can be filled in already from > the cache. When refreshing project info details for all project (when > cache is stale and has to be refreshed) generate projects info only if > modification time (as returned by lstat()) of projects repository > gitdir changed. > > This way we can avoid hitting repository refs, object database and > repository config at the cost of additional lstat. > > Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx> > --- > This is an idea for further improvement of 'projects list caching'. > Could you please: > > 1.) comment if it is a good idea, or why it works, or why it > couldn't work :), The idea is nice, but I'm surely missing something obvious again - why do you use lstat() as opposed to stat()? And more importantly, the mtime of projects repository unfortunately does not reflect almost any changes per se; you would need to check mtime of description file, config file and the refs instead. -- Petr "Pasky" Baudis Whatever you can do, or dream you can, begin it. Boldness has genius, power, and magic in it. -- J. W. von Goethe -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
