Re: [PATCH 06/16] add test_cmp function for test scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> On Wed, Mar 12, 2008 at 03:12:45PM -0700, Junio C Hamano wrote:
>
>> I think I have an earlier round of this in 'pu'.
>
> Oops, so you do. I remember discussing it but didn't recall a patch
> coming out of it.
>
> I see you have queued mine now in pu over yours. I actually think yours
> looks a little nicer (you sanity-check the comparator, and you are more
> careful with stdin (something that I considered, but figured we could
> add if something actually broke)).
>
> Any reason not to keep your existing one over mine?

Yours is much simpler.

And it is tested on the field, so if it ever breaks I have somebody else
to blame ;-)

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux