Re: [PATCH 11/16] config: add --literal-match option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> When limiting the values to be set (or returned), the user
> previously had the option of specifying a regex. In some
> cases, however, they may want to find a literal value. The
> option --literal-match converts any matching regex into a
> literal string comparison.
>
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> ---
> I think this is a nice addition regardless, but it is used by the next
> patch.
>
> The patch is about twice as long as it needs to be since getting and
> setting in builtin-config follow two almost-the-same parallel codepaths.
> I suspect this could be cleaned up, but I didn't look too closely.

I think that is a good new feature to propose.

Historically, the config_set_multivar() function has been one of the most
buggy part of the then-current codebase.  It might be a good idea to
clean-up first and then enhance.

But in either case I am quite reluctant to touch this part of the code
right now before 1.5.5, especially without extra sets of eyeballs.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux