Re: [PATCH 04/10] Make setup_work_tree() return new prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 11, 2008 at 8:27 PM, Johannes Schindelin<Johannes.Schindelin@xxxxxx> wrote:> Hi,>>>  On Sun, 2 Mar 2008, Nguyễn Thái Ngọc Duy wrote:>>  > worktree setup inside setup_git_directory*() is not perfect. It does not>  > take core.worktree into account. So when you do setup_work_tree(), the>  > real work tree may be not the one setup_git_directory*() gives you. You>  > need a new prefix in that case.>>  Probably the real fix would be to setup_git_directory(), no?
setup_work_tree() does the job fine. Why duplicate the code one more?In the old days, setup_git_directory() was just a simple wrapperaround setup_git_dir_gently(). I wanted to move it back to those days.And setup_git_directory() is fixed  in "Completely move out worktreesetup from setup_git_directory_gently()" so setup_git_directory() doescontain the real fix in the end.
>  Ciao,>  Dscho-- Duy��.n��������+%������w��{.n��������n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�m


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux