Hi, On Mon, 10 Mar 2008, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > ... > >> This fixes > >> > >> git config core.editor "c:/Program Files/What/Ever.exe" > >> > > > > Having sent a few messages about shell quoting, it makes me wonder if this > > was done very deliberately in the first place, so that you can do things > > like: > > > > git config core.editor "emacs -nw" > > > > Blame followed by list archive hunting around that timeperiod would tell. > > I'll let others look for the bug report and user request from the list > archive, but the pertinent commit is 5e2de4f9 (Fix $EDITOR regression > introduced by rewrite in C.): > > When git-tag and git-commit launches the editor, they used to > honor EDITOR="editor -options args..." but recent rewrite in C > insisted on $EDITOR to be the path to the editor executable. > > This restores the older behaviour. > > In other words, your example is a user error and your patch is a > regression. I was well aware of that commit when I wrote the patch, but... > I guess the right way to do that would be: > > git config core.editor '"c:/Program Files/What/Ever.exe"' > > but I do not do windows, so this is obviously untested. Ooops. The commit message I gave did not escape the double quotes, but I _meant_ to, promise! So yes, it was my intention that git config core.editor \"C:/Program\ Files/vim/vim71/gvim.exe\" works, but git config core.editor "C:/Program Files/vim/vim71/gvim.exe" does not. Note that the test was written correctly. Sorry, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
