Re: [PATCH 2/2] Fix git pull handling of the quiet option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Iustin Pop <iusty@xxxxxxxxx> writes:

> Although git pull has a documented quiet option,...

I think that is a documentation bug.  pull accepts all options for fetch
for the sole purpose of passing them intact to underlying fetch, and some
options to fetch does not even make much sense in the context of pull.

Also options to pull needs to come first; the options pull does not know
about is a signal for pull that the rest is for consumption of underlying
fetch.

If you want to teach --quiet to pull, however, your patch is the right
approach.  pull would eat --quiet and make a note for itself, and passes
that to underlying fetch (and perhaps merge).

You also need to sign-off your patch and add tests to make sure that other
people will not break your enhancement in the future.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux