John Goerzen <jgoerzen@xxxxxxxxxxxx> wrote: > On Saturday 08 March 2008 3:05:18 pm Junio C Hamano wrote: > > John Goerzen <jgoerzen@xxxxxxxxxxxx> writes: > > > Problem described here: > > > > > > http://thread.gmane.org/gmane.comp.version-control.git/76561 > > > > > > Signed-off-by: John Goerzen <jgoerzen@xxxxxxxxxxxx> for the actual code, not the commit message: Acked-by: Eric Wong <normalperson@xxxxxxxx> > > While I am sure Eric and git-svn users would appreciate a fix, please do > > not write a commit log message like this. > > > > Having a pointer to additional material is a very good practice, and will > > be appreciated by the readers, but giving a pointer and nothing else means > > that you are forcing your readers to hunt for out-of-line information. > > Thanks for the note. Some projects really hate long commit messages, and > some love them, and I wasn't sure what type of project this is. We are the latter :) One thing I've found with distributed VCS is that it's easier and convenient to write very detailed commit messages as documentation so I can go back and reference them easily. Also, the commit messages are written in the heat of the moment so the code is fresh in my mind rather than going back at the end and then writing more documentation/comments later on. With this synchronous behavior, the commit message will always valid for that particular changeset. Probably due to my workflow, I've always found asynchronously maintained code and documentation to be quite difficult and documentation always dragged behind. > Would you like me to rewrite and re-submit this, or are you editing and > committing? I'd prefer it'd be straight from the patch author's mouth/fingers :) Thanks John, -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
