Hi, On Sat, 8 Mar 2008, Santi Béjar wrote: > On Fri, Mar 7, 2008 at 5:41 PM, Alex Riesen <raa.lkml@xxxxxxxxx> wrote: > > Santi Béjar, Thu, Mar 06, 2008 22:45:43 +0100: > > > > > > > On Wed, Mar 5, 2008 at 9:44 PM, Alex Riesen <raa.lkml@xxxxxxxxx> wrote: > > > > Santi Béjar, Wed, Mar 05, 2008 20:18:04 +0100: > > > > > > > > > @@ -171,7 +171,7 @@ static const char au_env[] = "GIT_AUTHOR_NAME"; > > > > > static const char co_env[] = "GIT_COMMITTER_NAME"; > > > > > static const char *env_hint = > > > > > "\n" > > > > > -"*** Your name cannot be determined from your system services (gecos).\n" > > > > > +"*** Your name cannot be determined.\n" > > > > > > > > Why not? > > > > > > Is this important? Or in another way, is this useful? The important > > > thing is how you can fix it. But others think otherwise I'll change it > > > to explain the reason. > > > > It is precise explanation of what happened. It could be a hint to fix > > gecos field to someone. It is considered useful not to hide > > information, even if you have no idea of how useful it is. > > I'll wait for others to comment. I thought I asked why you had to remove the comment (which seems not to have a proper reasoning in the commit message), but maybe I did not. So here it is in writing: I agree with Alex on the criticism on this part of your patch. > > Others may be smarter than you. > > I don't think this is necessary. It is not necessary that others may be smarter than you, alright. Hth, Dscho
