Re: [PATCH v2 2/3] git-submodule: New subcommand 'summary' (2) - hard work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 8, 2008 at 12:59 AM, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> "Ping Yin" <pkufranky@xxxxxxxxx> writes:
>
>  > On Sat, Mar 1, 2008 at 3:29 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>  >> Ping Yin <pkufranky@xxxxxxxxx> writes:
>  >>
>  >>> +             test -z "$check_src" ||
>  >>> +             GIT_DIR="$name/.git" git-rev-parse --verify $sha1_src^0 >/dev/null 2>&1 ||
>  >>> +             unfound_src=t
>  >>
>  >>  You do not want to do ^0; you will not be bind a non-commit in gitlink
>  >>  entry anyway.
>  >>
>  > Actually, I need ^0. "git-rev-parse --verify sha1" will always
>  > succeed if sha1 is an valid name with lenght 40 even if the sha1
>  > doesn't belong to the repository.
>  >
>  > But what I want to verify is that the sha1 is not just valid/unique
>  > but also belongs to the submodule repository.
>
>  Don't you want "git cat-file -e <sha1>" then, unless you are checking
>  more than one sha1?
>
Hmm, yeah, the command you give has the same effect with
   "git-rev-parse --verify sha1^0"
>  --
>  Jakub Narebski
>  Poland
>  ShadeHawk on #git
>



-- 
Ping Yin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux