Re: [PATCH] t9001: set TERM=dumb to prevent ANSI output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 6 Mar 2008, Junio C Hamano wrote:

> Junio C Hamano <gitster@xxxxxxxxx> writes:
> 
> > Christian Couder <chriscool@xxxxxxxxxxxxx> writes:
> > ...
> >> This may not work well with colored output.
> >> In test-lib.sh line 62 there is :
> >>
> >> [ "x$TERM" != "xdumb" ] &&
> >> 	[ -t 1 ] &&
> >> 	tput bold >/dev/null 2>&1 &&
> >> 	tput setaf 1 >/dev/null 2>&1 &&
> >> 	tput sgr0 >/dev/null 2>&1 &&
> >> 	color=t
> >
> > Ahh.  Sorry about that.
> 
> Ahem, third time lucky.

Well, with this:

>  t/test-lib.sh |   24 +++++++++++++++++-------

I think it is no longer worth it _not_ to special-case it.  IOW I'd prefer 
my original patch for simplicity.

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux