Re: [PATCH 1/2 v2] Add strbuf_vaddf(), use it in strbuf_addf(), and add strbuf_initf()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 6 Mar 2008, Johannes Sixt wrote:

> Johannes Sixt schrieb:
> > You did not cater for PRIuMAX, which is %llu except on Windows, where 
> > it is %I64u. We can make it %llu on Windows only if we can ensure that 
> > none of its uses ends up in a regular *printf function!
> 
> Oh, well, PRIuMAX is *only* used in regular *printf and in die() calls. 
> That's fine, too.

Hey, no problem.  I used my earlier analysis to find the _minimal_ set of 
formats needed to get Git running without that vsnprintf().

The idea is, of course, to enhance vaddf() as needed (if at all).

Note: I did not even bother trying to convert any vsnprintf() users except 
for strbuf_addf() to that interface: it should be relatively easy, but 
there are quite a few sites (even using strbuf, but not addf() because 
only a va_list is available), so it is left as an exercise to the reader 
;-)

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux