Re: [PATCH] user.default: New config to prevent using the default values for user.*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 5 Mar 2008, Santi Béjar wrote:

> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 4027726..d7e5b6d 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -914,6 +914,11 @@ url.<base>.insteadOf::
>  	never-before-seen repository on the site.  When more than one
>  	insteadOf strings match a given URL, the longest match is used.
>  
> +user.default::
> +	If false the defaults values for user.email and user.name are not
> +	used. Useful when you want a different email/name for each
> +	repository, normally set in the global config file.
> +

I have to wonder: why do you set it in global config file the first place?

And the answer...

> diff --git a/ident.c b/ident.c
> index b839dcf..0f62a94 100644
> --- a/ident.c
> +++ b/ident.c
> @@ -75,7 +75,7 @@ static void setup_ident(void)
>  	struct passwd *pw = NULL;
>  
>  	/* Get the name ("gecos") */
> -	if (!git_default_name[0]) {
> +	if (!git_default_name[0] && default_ident) {
>  		pw = getpwuid(getuid());
>  		if (!pw)
>  			die("You don't exist. Go away!");

... is here.  You are actually not at all talking about the global config 
file, but the gecos information instead.

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux