Re: [PATCH] git-submodule: Don't die when command fails for one submodule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 4 Mar 2008, Ping Yin wrote:

> When handling multiple modules, init/update/status command will exit 
> when it fails for one submodule. This patch makes the command continue 
> bypassing the failure.

I think that you should not do this.  The failure should not be ignored.  
Maybe continuing, but not forgetting about the error.  So:

> -		name=$(module_name "$path") || exit
> +		name=$(module_name "$path") || continue

I do not like this.  It should remember that there was something foul, and 
eventually exit with that status.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux