Re: git-filter-branch may leave tree in a nasty state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mar 2 2008 20:40, Johannes Schindelin wrote:
>On Sun, 2 Mar 2008, Jan Engelhardt wrote:
>
>> $ git-filter-branch --env-filter 'export GIT_AUTHOR_NAME="";' b4caa441..HEAD
>> Rewrite cf1d02ac074041f7e570ff206d87fb47ef2b2c34 (1/1)fatal: empty ident  
>> <user@xxxxxxxx> not allowed
>
>Well, I kinda expected people savvy enough to run filter-branch to have 
>set up the proper ident ;-)

Nah, this is just the test case. The real scripts I use write
author, email and log message to a file in the env-filter hook,
call an editor where they can be arbitrarily changed, and then
the rest of the env-filter and msg-filter hooks parse the text
file back into the shell variables.

So I am changing the ident of existing commits (postprocessing
a non-git tree conversion).

The problem is that some editors clear the terminal window
(in other words, they are "full-screen"), so I did not get to
see the filter-branch error message at all because the next
editor invocation just popped in.

Most importantly, git-filter-branch should STOP when it detects
a problem, not try rewriting the next commit.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux