Re: [PATCH 2/3] specify explicit "--pretty=medium" with `git log/show/whatchanged`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Denis Cheng <crquan@xxxxxxxxx> writes:

> The following patch will introduce a new configuration variable,
> "format.pretty", from then on the pretty format without specifying
> "--pretty" might not be the default "--pretty=medium", it depends on
> the user's config. So all kinds of Shell/Perl/Emacs scripts that needs
> the default medium pretty format must specify it explicitly.
>
> Signed-off-by: Denis Cheng <crquan@xxxxxxxxx>
> ---
>  contrib/emacs/git.el             |    2 +-
>  contrib/hooks/post-receive-email |    2 +-
>  git-cvsserver.perl               |    2 +-
>  git-merge.sh                     |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

I think --pretty is enough and you do not have to say --pretty=medium, but
as long as we are being explicit, we'd better be fully explicit to future
proof them.

The list of in-tree users and places match what I found with my quick
review, which hopefully means both of us did our best effort to catch
potential breakages.

Thanks.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux