Re: [PATCH 0/5] Builtin "git remote"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, 2 Mar 2008, Johannes Schindelin wrote:

> diff --git a/builtin-log.c b/builtin-log.c
> index bbadbc0..17e491b 100644
> --- a/builtin-log.c
> +++ b/builtin-log.c
> @@ -694,7 +694,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
>  	if (!origin)
>  		return;
>  
> -	diff_setup(&opts);
> +	memcpy(&opts, &rev->diffopt, sizeof(opts));
>  	opts.output_format |= DIFF_FORMAT_SUMMARY | DIFF_FORMAT_DIFFSTAT;
>  
>  	diff_setup_done(&opts);

Ooops, I forgot to "make test"!  And sure enough, t4013 breaks, because 
the "|=" was bogus to begin with.

Will resend, together with a patch to wrap the shortlog nicely.

... after "make test" ;-)

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux