On Fri, 29 Feb 2008, Shawn O. Pearce wrote: > Daniel Barkalow <barkalow@xxxxxxxxxxxx> wrote: > > On Fri, 29 Feb 2008, Shawn O. Pearce wrote: > > > > > Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > > This is cute. Obviously some tests need to be adjusted for this > > > > change, though. > > > > > > I'll take a look at the current tests this weekend and see what > > > needs to be adjusted, if anything. I'd also like to get a few > > > tests written for this, so we are certain the optimizations are > > > kicking in when they are supposed to be. > > > > I'd be really grateful if you came up with a good general strategy for > > testing that we're not doing too much work in fetching, because clone has > > optimizations that I need to test in a similar way, and I haven't been > > able to think of anything not horribly intrusive. > > Is this "horribly intrusive" ? > > We can test it with something like this: That looks suitable to me (although maybe the environment variable should contain the fd to write to?). I also want to know the "have" info, so I can verify that the client is listing things appropriately, but that's an obvious addition. -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
