Re: [PATCH 27/40] Windows: Implement a custom spawnve().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 28 Feb 2008, Johannes Sixt wrote:

> On Thursday 28 February 2008 16:36, Johannes Schindelin wrote:
> > On Wed, 27 Feb 2008, Johannes Sixt wrote:
> > > -	cmd->pid = spawnvpe(_P_NOWAIT, cmd->argv[0], cmd->argv, (const 
> char**)env); 
> > > +	cmd->pid = mingw_spawnvpe(cmd->argv[0], cmd->argv, env);
> >
> > Should this not be "#define spawnvpe mingw_spanvpe" in git-compat-util.h
> > instead?
> 
> No. We don't mimic the API of the original spawnvpe. Why obfuscate this fact?

Oops.  I forgot that.  Maybe we do not want to call the function 
mingw_spawnvpe(), then?  (That fact is what made me believe that the 
#define was a good idea, after all.)

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux