Hi,
On Thu, 28 Feb 2008, Johannes Sixt wrote:
> On Thursday 28 February 2008 13:05, Johannes Schindelin wrote:
> >
> > On Wed, 27 Feb 2008, Johannes Sixt wrote:
> >
> > > +#ifdef __MINGW32__
> > > +int mkstemp(char *template);
> > > +#endif
> > > +
> > > static inline int xmkstemp(char *template)
> > > {
> > > int fd;
> >
> > Could we have this...
>
> No, becauser xmkstemp needs the forward declaration of mkstemp(). But we
> could make it unconditional.
Actually, I was thinking of including it at the same spot where you
declare mkstemp conditionally. (Of course, since I spotted very well that
you need that declaration for xmkstemp().)
> I thought about this, but I decided against it: git-compat-util.h is
> the place to look for compatibility functions. A file compat/mingw.h
> only introduces an extra indirection and only *hides* stuff instead of
> making it obvious.
Well, the thing is, there are quite a few definitions and declarations
that are _only_ _ever_ interesting if you are on MinGW32.
So maybe it is a good idea to hide it to all the other users.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
