On Thursday 28 February 2008 10:25, Paolo Bonzini wrote: > > +#ifdef __MINGW32__ > > + strbuf_addch(out, ';'); > > +#else > > strbuf_addch(out, ':'); > > +#endif > > Why not adding a PATH_SEPARATOR #define? Because IMO it is obfuscating: 1. When you read through the code and see PATH_SEPARATOR, you still have to go look how it's defined. Why? Because you always will ask: Is this about ':' vs. ';' or '/' vs. '\\'? 2. When you look for where ":" or ";" are treated, you'll end up at the #define. Then you need an extra step to search for PATH_SEPARATOR. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
