Hi, On Thu, 28 Feb 2008, Nguyen Thai Ngoc Duy wrote: > On Thu, Feb 28, 2008 at 6:30 PM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > > I am sorry, but with all these intrusive changes, I get a very uneasy > > feeling. As uneasy as with the original series, which I tried to fix > > up, not really succeeding. > > In constrast I feel good :) To me setup_git_directory*() at the end look > really nice. No chdir() all over the place (temporary chdir() for > detecting .git does not count). It also gives a chance to get rid of > worktree to commands that do not care about worktree at all. Well, I'll have to review your patches in depth, then. Which will take some days, because I wanted to submit builtin-remote first. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
