Re: [PATCH] http-push: add regression tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 27 Feb 2008, Clemens Buchacher wrote:

> Networking tests are disabled by default. Use GIT_TEST_OPTS=--network to
> enable.

One request in addition to Mike's: please make this an environment 
variable such as "GIT_TEST_HTTPD".  IOW, instead of this:

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 83889c4..e33b13b 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -79,8 +79,10 @@ do
>  		verbose=t; shift ;;
>  	-q|--q|--qu|--qui|--quie|--quiet)
>  		quiet=t; shift ;;
> +	-n|--n|--ne|--net|--netw|--netwo|--networ|--network)
> +		network=t; shift ;;
>  	--no-color)
> -	    color=; shift ;;
> +		color=; shift ;;
>  	--no-python)
>  		# noop now...
>  		shift ;;
> @@ -89,6 +91,11 @@ do
>  	esac
>  done
>  
> +if test -n "$network"
> +then
> +	GIT_TEST_NET=t
> +fi
> +
>  if test -n "$color"; then
>  	say_color () {
>  		case "$1" in

just rename the variable "GIT_TEST_NET" in lib-httpd.sh to 
"GIT_TEST_HTTPD".

Thanks,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux