On Wed, Feb 27, 2008 at 08:20:12AM +0100, Mike Hommey wrote:
> On Tue, Feb 26, 2008 at 05:46:21PM -0600, Ken.Fuchs@xxxxxxxxx wrote:
> > > Well, the CURLOPT_PROXY is set in transport.c as well which
> > > your patch didn't address.
> >
> > Thanks, I just did a similar patch to transport.c:
> >
> > $ diff -u ../git-1.5.4.2/transport.c.orig \
> > ../git-1.5.4.2/transport.c
> > @@ -456,7 +456,8 @@
> > if (transport->remote->http_proxy)
> > curl_easy_setopt(slot->curl, CURLOPT_PROXY,
> > transport->remote->http_proxy);
> > -
> > + curl_easy_setopt(slot->curl, CURLOPT_PROXYAUTH,
> > (long)CURLAUTH_NTLM);
> > + curl_easy_setopt(slot->curl, CURLOPT_PROXYUSERPWD,
> > "<user-id>:<password>");
> > if (start_active_slot(slot)) {
> > run_active_slot(slot);
> > if (results.curl_result != CURLE_OK) {
> > $
>
> Starting with curl 7.14.1, you're supposed to be able to use the
> http://user:pass@proxy/ syntax, though I'm not sure it deals well with
> NTLM domains. You can probably leave CURLOPT_PROXYUSERPWD out if you
> set your proxy url correctly.
>
> As for CURLOPT_PROXYAUTH, it would be better to set it from another
> config.
Or we should set it to CURLOPT_AUTHANY by default.
Mike
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
