On Tue, Feb 26, 2008 at 12:05:46PM -0500, Nicolas Pitre wrote: > > For example, it seems easy to do this: > > > > git config pack.thread 4 > > git repack > > > > The user would immediately know something was wrong when they saw the > > message "Using 1 pack threads" instead of the "4" they thought they > > configured. > > Maybe a message for any unrecognized config option should be displayed > instead. I think that is generally useful, though it is somewhat hard with our config parsing mechanism. You could handle specific cases like "I'm in git_pack_config, this is a pack.* variable, and I don't understand it". But it would be nice to have a general "no callback claimed to understand this variable" which I think is impossible (since we do things like parsing the config just to grab a small part of it). > Also, I think that such message should absolutely not be sent over in > the context of a fetch/clone. This is a local matter only, and should > be displayed only when those progress messages are meant for the local > user. > > Therefore I propose this patch instead: I think that is a nice addition to my patch, but I am also fine with simply reverting 6c723f5e entirely, as Brandon suggested. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
