Re: [PATCH] rev-parse: fix potential bus error with --parseopt option spec handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 25 Feb 2008, Jay Soffian wrote:

> diff --git a/builtin-rev-parse.c b/builtin-rev-parse.c
> index b9af1a5..90dbb9d 100644
> --- a/builtin-rev-parse.c
> +++ b/builtin-rev-parse.c
> @@ -315,7 +315,7 @@ static int cmd_parseopt(int argc, const char **argv, const char *prefix)
>  		s = strchr(sb.buf, ' ');
>  		if (!s || *sb.buf == ' ') {
>  			o->type = OPTION_GROUP;
> -			o->help = xstrdup(skipspaces(s));
> +			o->help = xstrdup(skipspaces(sb.buf));

Looks obviously correct, but I would have expected a SIGSEGV, not a 
SIGBUS.

Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux