Re: [PATCH v3] builtin-fsck: reports missing parent commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Martin Koegler <mkoegler@xxxxxxxxxxxxxxxxx> writes:

> Signed-off-by: Martin Koegler <mkoegler@xxxxxxxxxxxxxxxxx>

As far as I can tell, the new test is not testing the commit
object we are looking at from the object database.  What it is
testing is if the code that parsed and prepared the information
in "struct commit" found the same number of parents an extra
check we are doing here by hand (if not grafted --- but
presumably whoever gave the struct commit we are handling here
would have obtained that information by doing the same parsing),
or the parsing of the graft file (when grafted --- but
presumably whoever gave the struct commit we are handling here
would have obtained that information by calling the same
llokup_commit_graft()).

So I am not sure what problems in the repository objects these
new checks are designed to catch.

This needs a lot of explanation than what's in your commit log
message.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux