Re: [RFC/PATCH v2] gitweb: Option to chop at beginning and in the middle in chop_str

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> Make use of new feature of chop_str to better cut matched string and
> its context in match info for searching commit messages (commit
> search), as proposed by Junio C Hamano.  For example, if you are
> looking for "very long ... and how" in the first paragraph of this message
> (if it were all on a single line), you would now see:
>
>     ...st this with <<very long ... and how>> the actual out...
>
> instead of:
>
>     Could som... <<very long search stri...>> the actual out...
>
> (where <<something>> denotes emphasized / colored fragment).

This part needs rewritten; the first paragraph of what message is that?  

Also I think the subject is wrong.  Yes, it is adding an option
to an internal subroutine but who cares?  The net effect the
"gitweb" users see is that the way the grep result is shown
differently, hopefully in a more understandable way, and that
change is not _optional_ at all.

The code looks easier to read than before, but I may be partial
;-)

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux