Paul Mackerras wrote:
Gerrit Pape writes:
Saving the geometry can cause several inconveniences, e.g. when using a
temporary dual screen setup, or sharing ~/.gitk between multiple
systems. Additionally it can be argued that window placement and sizing
are the tasks of the window manager. So don't do that anymore.
I myself find it useful to have gitk remember the size and layout of
the various panes, so I won't be applying this patch.
The saving/restoring of the window position was done by Mark Levedahl
to make gitk work properly on Cygwin. I agree it can be annoying on X
and I would take a patch to inhibit the restoring of the window
position when running under X. I'd want an ack from Mark before
making that change more generally.
Paul.
I can only offer to test the proposed patch, I am unable to predict what
will or won't trip up the buggy geometry engine in Cygwin's Tk. I do
remember I had trouble finding a way to restore the size but not the
position of the main window on Cygwin: that doesn't mean it can't be
done (logically, it should be easy), just that I didn't find the right
spell or incantation that would work. I'll also admit to not having
tried after I got to a completely working geometry solution, so perhaps
just restoring the size without position will now work on Cygwin.
Using the saved panel sizes in conjunction with the default window size
yields an unusable screen: many elements are obscured. The same occurs
using the defaults altogether: either way the user must resize and
adjust things to get to a workable layout. So, I am very opposed to
disabling the memory altogether. Also, I have a number of X apps that
remember their layout, so gitk's current behavior is not (at least to
me) an aberration and I would like that behavior to at least remain an
option.
Mark
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
