Hi,
On Sat, 23 Feb 2008, Morten Welinder wrote:
> > +inline void gitfree(void *ptr)
> > +{
> > + if (ptr)
> > + free(ptr);
> > +}
> > +#define free gitfree
> > +#endif
>
> I am wondering why you do it this way. "#define free gitfree" is just
> not valid in a C program that includes the relevant standard header.
> "free" is a reserved symbol.
>
> To stay within the standard, do the define the other way and use
> gitfree everywhere.
We do it this way for other things like fopen, too.
Besides, I think that there should be at least one _real_ case where it
actually _breaks_ before we have a big, ugly, change where it is easy to
overlook a non-converted "free()", instead of a nice, clean and short
patch.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
