Re: [PATCH] t4014: Replace sed's non-standard 'Q' by standard 'q'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Steffen Prohaska <prohaska@xxxxxx> writes:

> This commit should be applied on top of db/cover-letter.
>
> -- >8 --
>
> This commit avoids sed's 'Q' operator.  The Open Group's sed
> man page [1] does not mention 'Q'.  sed on Mac OS X 10.4
> does not accept Q.  'q' is sufficient for our purpose.

Thanks.

> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index a39e786..16aa99d 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -95,7 +95,7 @@ test_expect_success 'extra headers' '
>  	git config --add format.headers "Cc: S. E. Cipient <scipient@xxxxxxxxxxx>
>  " &&
>  	git format-patch --stdout master..side > patch2 &&
> -	sed -e "/^$/Q" patch2 > hdrs2 &&
> +	sed -e "/^$/q" patch2 > hdrs2 &&
>  	grep "^To: R. E. Cipient <rcipient@xxxxxxxxxxx>$" hdrs2 &&
>  	grep "^Cc: S. E. Cipient <scipient@xxxxxxxxxxx>$" hdrs2
>  	

I usually try to be pretty careful about these kind of things,
but these somehow slipped in.  Changing them to 'q' means the
output will now have an additional blank line at the end, but
that would not affect the result the later tests inspect, so
it's a good change.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux