Junio C Hamano, Thu, Feb 21, 2008 21:56:52 +0100: > Alex Riesen <raa.lkml@xxxxxxxxx> writes: > > > In this one. I am a bit unsure regarding the change (it looks a little > > too strong), even though it passes the test suite. > > I think that is because your new test is faulty. > > Instead of ':' I complained about, try having "echo foo" there. > I think it will still fail. Oh, indeed. The commit to amend does not introduce any changes. > Having said that, here is a quiz. When the user says "git > commit --amend", what are the valid reasons not to allow it, > other than: > > - the index is unmerged. > - the branch is yet to be born. There are no tree changes in the commit to be amended. And if there is a strong wish to do just the amendment, there is always --allow-empty. Ok, it must have been the amount of err... tee I just had. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html