On Wed, Feb 20, 2008 at 04:34:25PM -0800, Junio C Hamano wrote: > > - Sun's diff doesn't understand "-u". I was able to use GNU diff. > > Since comparing actual and expected output is so common, we could > > potentially abstract this with a "test_cmp()" function and use > > something platform specific. It's probably not worth the trouble, as > > it impacts only the test suite, and only on systems with a totally > > broken diff. > > It is unfair to call diff without -u "totally broken". It is > not even in POSIX yet IIRC. Fair enough (and you are right that it is not even POSIX). Is it something we want to work around? We "diff -u" quite a bit in the test suite. > > - t7505 uses a hook which hard-codes /bin/sh but uses syntax that > > the Solaris /bin/sh doesn't like. Maybe hooks should get their > > $SHELL value replaced? > > You've already did that in your [PATCH 2/3], haven't you? So > why not? Because I didn't look very closely, and I assumed it was one of the regular hooks. But yes, it is defined in the script and could get the same treatment. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
