Re: [PATCH] send-email: squelch warning due to comparing undefined $_ to ""

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jay Soffian <jaysoffian@xxxxxxxxx> writes:

> The check to see if initial_reply_to is defined was also comparing $_ to
> "" for a reason I cannot ascertain (looking at the commit which made the
> change didn't provide enlightenment), but if $_ is undefined, perl
> generates a warning.
>
> Signed-off-by: Jay Soffian <jaysoffian@xxxxxxxxx>
> ---
> Junio, the commit which introduced the change was yours, but I don't
> see why you were comparing $_ to "". 

I think it was meant to check for $initial_reply_to being empty
(i.e. not compare $_ but the variable), but even if that is the
case I do not think the check would make a difference.

So the patch looks good.  Thanks.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux