Hi,
On Tue, 19 Feb 2008, Jay Soffian wrote:
> + if (!tracking.matches)
> + switch (track) {
> + case BRANCH_TRACK_ALWAYS:
> + case BRANCH_TRACK_EXPLICIT:
> + break;
> + default:
> + return 1;
> + }
I'd write that as
if (!tracking.matches &&
(track == BRANCH_TRACK_ALWAYS || track == BRANCH_TRACK_EXPLICIT))
return 1;
but that is really niggling about style...
As you can see, I have no real objections ;-)
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
