Hi, On Tue, 19 Feb 2008, Mike Hommey wrote: > On Tue, Feb 19, 2008 at 01:17:24PM +0000, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > > On Tue, 19 Feb 2008, Clemens Buchacher wrote: > > > > > On Mon, Feb 18, 2008 at 05:34:45PM +0000, Johannes Schindelin wrote: > > > > > > > Thanks for the patch, I think it good. Now, if we only had > > > > automated tests... ;-) > > > > > > Thank you. Implementing a test should be fairly difficult, since we > > > need at least a WebDAV capable webserver, right? Do you having > > > something in mind? > > > > Actually, thinking about it again, it should not be _that_ difficult. > > We would need to ship a httpd.conf.in, pick a port (maybe 8111, > > because that is already used in t5703-daemon.sh), generate httpd.conf > > and then start Apache with that. > > > > If Apache does not want to start, skip this test. (This might happen > > due to Apache not being installed, or the DAV modules not being > > installed, or Apache not finding them, or...) > > Except that means coping with the fact that modules are probably not > installed in the same place on all distros, or can have been built in > apache instead of being DSOs, etc. The server itself doesn't even have > the same name across distros (httpd vs. apache vs. apache2) I think this would not be too much of a hassle. These days, an Apache2 is installed on many machines, and it is better to have tests, than to have no tests, even if they are not exercised everywhere, right? Besides, for those machines that do not have Apache installed (such as MinGW based setups), we can always add yet another environment variable, say "HTTP_PUSH_TEST_URL" to tell the test that there is already a web server set up at that URL, ready to be used. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
