Hi,
On Mon, 18 Feb 2008, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>
> >> The script uses File::Basename upfront so perhaps just simply...
> >
> > I tried that. But as the file need not exist, "basename" went on
> > strike.
> >
> > So I'll keep the (ugly) version.
>
> The reason why "basename" is not being used needs documented in the code
> then. The next person will likely to make the same mistake as I did.
Right. Could you be so good and squash this in, then, please?
Thanks,
Dscho
-- snipsnap --
diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index c00368b..6eff42c 100755
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -208,6 +208,7 @@ if (@canstatusfiles) {
my %fullname = ();
foreach my $name (keys %todo) {
my $basename = $name;
+ # cannot use basename(), since $name need not exist in the CVS tree
$basename =~ s/.*\///;
$basename = "no file " . $basename if (exists($added{$basename}));
chomp($basename);
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
