On Feb 18, 2008 9:05 AM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi, > > On Mon, 18 Feb 2008, Jay Soffian wrote: > > > Incorporated Johannes' second round of feedback. > > Not exactly. Heh... > This looks completely different than what I commented on. And my comments > suggested a different solution. Thought process went like this: - fix sprintf() to use snprintf() - notice setup_tracking() uses sprintf() and think about fixing it too - realize setup_tracking() does bounds checking first and its use of sprintf() is therefor safe. - go to copy the bounds checking code from setup_tracking() to the area you commented on. - realized duplicating the code was dumb and I could just re-use what was already in setup_tracking() via what was just sent. > But you can use the time to write some tests ;-) Sure I can. I really hope after all this work the patch gets accepted. j. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
