Hi, On Mon, 18 Feb 2008, Lars Hjemli wrote: > On Feb 18, 2008 1:34 PM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > > > [* snip *] > > > > So maybe we can just scratch all that, and I agree that an invalid > > .git file means "no repository" (as opposed to "no valid repository"). > > > > In that case, you might want to test for that, too... > > I think I do, did you find a loophole in the testing? I meant writing a readable, but invalid .git file. Then testing that Git die()s with the correct message. > > Speaking about tests: > > > > > +test_expect_success 'setup' ' > > > + REAL="$(pwd)/.real" && > > > + mv .git "$REAL" && > > > + echo "gitdir: $REAL" >.git > > > +' > > > > Let's not do this. It would clutter the t/ directory unnecessarily. > > What do you mean? The test just moves t/trash/.git to t/trash/.real... Oh, well. I'll go and buy me some new glasses. Thanks, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html