On Feb 18, 2008 1:17 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > On Mon, 18 Feb 2008, Lars Hjemli wrote: > > > The patch-series has been reordered and updated according to comments on > > the earlier series. > > It would be easier on a stupid reviewer like me, if you summarised what > you changed. Ok, I'll keep that in mind next time, and here's a quick summary (from the top of my head) of this series vs. the previous: * patch 1 and 2 are swapped, since the changes to git-sh-setup.sh can be applied onto master regardless of the rest of the patch series (while the other patches still rely on 1/5). * git-sh-setup.sh is simplified even further, and relies on git-rev-parse to produce the error message when no gitdir can be found. * read_gitfile_gently() is moved from environment.c into setup.c since it now invokes is_git_directory(). * read_gitfile_gently() will gently ignore a 'missing' .git or a .git which isn't a regular file, but die()s on all other errors. > In the case of patch "1/5 => 2/5", I would even have > appreciated an interdiff... Sorry, but I don't think I understand what you mean by interdiff. > > Oh, and I was kind of surprised to learn that it is the ".gitfile", not > the ".git file"... I ran to your patch straight away, and was relieved > when I found out that you still call it ".git". Yeah, I suck really bad on consistency ;-) -- lh - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
