Hi, On Mon, 18 Feb 2008, Lars Hjemli wrote: > On Feb 18, 2008 6:43 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Lars Hjemli <hjemli@xxxxxxxxx> writes: > > > > > +/* > > > + if (!is_git_directory(buf + 8)) > > > + return NULL; > > > +*/ > > > > Likewise. > > True, I'll uncomment and die(). Hmm. From check_repository_format_gently(): if (!nongit_ok) die ("...") warning("Expected git repo version <= %d..."); I think we want that, too. (die() when !nongit_ok, but warn otherwise) Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html