måndagen den 18 februari 2008 skrev du: > The Differencer I changed was actually a bug. If you say that the files > left in the left pane are Differencer.ADDITION, then the ones left on > the right pane _must_ be Differencer.DELETION. It just doesn't make > sense to say that files not on the old tree but on the new tree are > addition, and at the same time that files on the old tree but not on the > new tree are also addition. Ok, I see. I'll test it a little and push soon. > > I'd love to see a unit test for your code since, even if it works, it is very easy > > to break again. > > > Ok, I'll get a look on the test cases and probably write something when > I get back into these compare issues. That if somebody else doesn't do > it before me, of course :) Not very likely within a short time frame, though I want do the excersize. Unfortunately I have too many open branches right now to add yet another. The original author (cough, cough) didn't do it. I was so happy and pleased, at them time, to see it work at all so easiliy :) . I've written some tests for other functions, so I guess it's mostly about setting up some more infrastructure to make testing reasonably simple. -- robin - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
