On Sun, 17 Feb 2008, Shawn O. Pearce wrote: > Nicolas Pitre <nico@xxxxxxx> wrote: > > > > I should really come around to fixing packed_object_info_detail() for > > the OBJ_OFS_DELTA case one day. > > Please don't. > > Obtaining the SHA-1 of your delta base would require unpacking your > delta base and then doing a SHA-1 hash of it. Or alternatively > doing a search through the .idx for the object that starts at the > requested OFS. I intended to use the pack index of course. And the code already exists in pack-objects as find_packed_object(). > Either way, its really expensive for a minor detail > of output in verify-pack. Not _that_ expensive actually. Like I say, in pack-objects we do it all the time. > But if you are going to do that, you may also want to fix the > "*store_size = 0 /* notyet */" that's like 5 lines above. :) Yeah, that's easy too. Nicolas - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
